---

This section details on the original issue you should resolve

<issue_title>[duplicate-code] Update entity config parsing duplicated across update-issue/discussion/PR</issue_title>
<issue_description># 🔍 Duplicate Code Detected: Update entity config parsing duplicated across update-issue/discussion/PR

Analysis of commit be57766

Assignee: @copilot

Summary

The parsing logic for safe-output update jobs is copy-pasted across issue, discussion, and pull-request compilers. Each file builds the same parseUpdateEntityConfig call and re-parses per-field booleans in nearly identical blocks. This invites drift in validation defaults and logging.

Duplication Details

Pattern: Repeated update entity parsing scaffolding

• Severity: Medium
• Occurrences: 3
• Locations:
  • pkg/workflow/update_issue.go:18-60
  • pkg/workflow/update_discussion.go:19-70
  • pkg/workflow/update_pull_request.go:17-60
• Code Sample:

  params := UpdateEntityJobParams{EntityType: UpdateEntityIssue, ConfigKey: "update-issue"}
  parseSpecificFields := func(configMap map[string]any, baseConfig *UpdateEntityConfig) {}
  baseConfig := c.parseUpdateEntityConfig(outputMap, params, updateIssueLog, parseSpecificFields)
  if baseConfig == nil { return nil }
  updateIssuesConfig := &UpdateIssuesConfig{UpdateEntityConfig: *baseConfig}
  if configData, exists := outputMap["update-issue"]; exists {
      if configMap, ok := configData.(map[string]any); ok {
          if _, exists := configMap["title"]; exists { updateIssuesConfig.Title = new(bool) }
          // ...same structure repeats in discussion/PR variants...
      }
  }

Impact Analysis

• Maintainability: Three near-identical parsers must be edited in lockstep; adding new flags or changing defaults risks inconsistent behavior.
• Bug Risk: Drift between entities can silently mis-parse fields (e.g., nil vs false handling) and complicate validation fixes.
• Code Bloat: Repeated scaffolding inflates compiler size with no functional difference.

Refactoring Recommendations

1. Extract shared parser helper

   • Introduce a helper (e.g., parseUpdateEntityBooleans) that accepts ConfigKey, EntityType, and a map of field handlers (title/body/status/labels) and returns a populated config struct.
   • Estimated effort: 2-3 hours; simplifies adding new update targets.
   • Benefits: Single point for defaults/logging/validation; reduces drift.

2. Normalize field parsing strategy

   • Define declarative field descriptors (name, default behavior, coercion rules) and iterate rather than branching per file.
   • Estimated effort: 2 hours after helper; improves testability and makes future entities cheaper.

Implementation Checklist

• Review duplication findings
• Prioritize refactoring tasks
• Create refactoring plan
• Implement changes
• Update tests
• Verify no functionality broken

Analysis Metadata

• Analyzed Files: 6 (focus on update_* compilers and supporting parsers)
• Detection Method: Serena semantic code analysis
• Commit: be57766
• Analysis Date: 2025-02-16

AI generated by Duplicate Code Detector

Comments on the Issue (you are @copilot in this section)